Browse Source

Merge pull request #293 from DevFactory/release/methods-named-equals-should-override-object-equals

Code quality fix - Methods named "equals" should override Object.equals(Object)
master
Nikita Koksharov 10 years ago
parent
commit
f46c509a13
  1. 4
      src/main/java/com/corundumstudio/socketio/annotation/ScannerEngine.java

4
src/main/java/com/corundumstudio/socketio/annotation/ScannerEngine.java

@ -36,7 +36,7 @@ public class ScannerEngine {
private Method findSimilarMethod(Class<?> objectClazz, Method method) {
Method[] methods = objectClazz.getDeclaredMethods();
for (Method m : methods) {
if (equals(m, method)) {
if (isEquals(m, method)) {
return m;
}
}
@ -86,7 +86,7 @@ public class ScannerEngine {
}
private boolean equals(Method method1, Method method2) {
private boolean isEquals(Method method1, Method method2) {
if (!method1.getName().equals(method2.getName())
|| !method1.getReturnType().equals(method2.getReturnType())) {
return false;

Loading…
Cancel
Save