Browse Source

Fixing squid:S1161 @Override annotation should be used on any method overriding

master
Faisal Hameed 10 years ago
committed by faisal-hameed
parent
commit
cbea4bdf59
  1. 5
      src/main/java/com/corundumstudio/socketio/JsonSupportWrapper.java
  2. 1
      src/main/java/com/corundumstudio/socketio/SocketIOChannelInitializer.java
  3. 3
      src/main/java/com/corundumstudio/socketio/annotation/OnConnectScanner.java
  4. 1
      src/main/java/com/corundumstudio/socketio/handler/WrongUrlHandler.java
  5. 1
      src/main/java/com/corundumstudio/socketio/listener/DefaultExceptionListener.java
  6. 3
      src/main/java/com/corundumstudio/socketio/namespace/Namespace.java
  7. 1
      src/main/java/com/corundumstudio/socketio/protocol/JacksonJsonSupport.java
  8. 5
      src/main/java/com/corundumstudio/socketio/scheduler/HashedWheelScheduler.java
  9. 5
      src/main/java/com/corundumstudio/socketio/scheduler/HashedWheelTimeoutScheduler.java
  10. 1
      src/main/java/com/corundumstudio/socketio/store/RedissonStoreFactory.java
  11. 1
      src/main/java/com/corundumstudio/socketio/store/pubsub/BaseStoreFactory.java

5
src/main/java/com/corundumstudio/socketio/JsonSupportWrapper.java

@ -37,6 +37,7 @@ class JsonSupportWrapper implements JsonSupport {
this.delegate = delegate;
}
@Override
public AckArgs readAckArgs(ByteBufInputStream src, AckCallback<?> callback) throws IOException {
try {
return delegate.readAckArgs(src, callback);
@ -47,6 +48,7 @@ class JsonSupportWrapper implements JsonSupport {
}
}
@Override
public <T> T readValue(String namespaceName, ByteBufInputStream src, Class<T> valueType) throws IOException {
try {
return delegate.readValue(namespaceName, src, valueType);
@ -57,6 +59,7 @@ class JsonSupportWrapper implements JsonSupport {
}
}
@Override
public void writeValue(ByteBufOutputStream out, Object value) throws IOException {
try {
delegate.writeValue(out, value);
@ -66,10 +69,12 @@ class JsonSupportWrapper implements JsonSupport {
}
}
@Override
public void addEventMapping(String namespaceName, String eventName, Class<?> ... eventClass) {
delegate.addEventMapping(namespaceName, eventName, eventClass);
}
@Override
public void removeEventMapping(String namespaceName, String eventName) {
delegate.removeEventMapping(namespaceName, eventName);
}

1
src/main/java/com/corundumstudio/socketio/SocketIOChannelInitializer.java

@ -196,6 +196,7 @@ public class SocketIOChannelInitializer extends ChannelInitializer<Channel> impl
return serverContext;
}
@Override
public void onDisconnect(ClientHead client) {
ackManager.onDisconnect(client);
authorizeHandler.onDisconnect(client);

3
src/main/java/com/corundumstudio/socketio/annotation/OnConnectScanner.java

@ -26,10 +26,12 @@ import com.corundumstudio.socketio.namespace.Namespace;
public class OnConnectScanner implements AnnotationScanner {
@Override
public Class<? extends Annotation> getScanAnnotation() {
return OnConnect.class;
}
@Override
public void addListener(Namespace namespace, final Object object, final Method method, Annotation annotation) {
namespace.addConnectListener(new ConnectListener() {
@Override
@ -45,6 +47,7 @@ public class OnConnectScanner implements AnnotationScanner {
});
}
@Override
public void validate(Method method, Class clazz) {
if (method.getParameterTypes().length != 1) {
throw new IllegalArgumentException("Wrong OnConnect listener signature: " + clazz + "." + method.getName());

1
src/main/java/com/corundumstudio/socketio/handler/WrongUrlHandler.java

@ -37,6 +37,7 @@ public class WrongUrlHandler extends ChannelInboundHandlerAdapter {
private final Logger log = LoggerFactory.getLogger(getClass());
@Override
public void channelRead(ChannelHandlerContext ctx, Object msg) throws Exception {
if (msg instanceof FullHttpRequest) {
FullHttpRequest req = (FullHttpRequest) msg;

1
src/main/java/com/corundumstudio/socketio/listener/DefaultExceptionListener.java

@ -43,6 +43,7 @@ public class DefaultExceptionListener extends ExceptionListenerAdapter {
log.error(e.getMessage(), e);
}
@Override
public boolean exceptionCaught(ChannelHandlerContext ctx, Throwable e) throws Exception {
log.error(e.getMessage(), e);
return true;

3
src/main/java/com/corundumstudio/socketio/namespace/Namespace.java

@ -86,6 +86,7 @@ public class Namespace implements SocketIONamespace {
allClients.put(client.getSessionId(), client);
}
@Override
public String getName() {
return name;
}
@ -331,6 +332,7 @@ public class Namespace implements SocketIONamespace {
return result;
}
@Override
public Collection<SocketIOClient> getAllClients() {
return Collections.unmodifiableCollection(allClients.values());
}
@ -339,6 +341,7 @@ public class Namespace implements SocketIONamespace {
return jsonSupport;
}
@Override
public SocketIOClient getClient(UUID uuid) {
return allClients.get(uuid);
}

1
src/main/java/com/corundumstudio/socketio/protocol/JacksonJsonSupport.java

@ -204,6 +204,7 @@ public class JacksonJsonSupport implements JsonSupport {
{
private final ThreadLocal<List<byte[]>> arrays = new ThreadLocal<List<byte[]>>() {
@Override
protected List<byte[]> initialValue() {
return new ArrayList<byte[]>();
};

5
src/main/java/com/corundumstudio/socketio/scheduler/HashedWheelScheduler.java

@ -36,6 +36,7 @@ public class HashedWheelScheduler implements CancelableScheduler {
this.ctx = ctx;
}
@Override
public void cancel(SchedulerKey key) {
Timeout timeout = scheduledFutures.remove(key);
if (timeout != null) {
@ -43,6 +44,7 @@ public class HashedWheelScheduler implements CancelableScheduler {
}
}
@Override
public void schedule(final Runnable runnable, long delay, TimeUnit unit) {
executorService.newTimeout(new TimerTask() {
@Override
@ -52,6 +54,7 @@ public class HashedWheelScheduler implements CancelableScheduler {
}, delay, unit);
}
@Override
public void scheduleCallback(final SchedulerKey key, final Runnable runnable, long delay, TimeUnit unit) {
Timeout timeout = executorService.newTimeout(new TimerTask() {
@Override
@ -74,6 +77,7 @@ public class HashedWheelScheduler implements CancelableScheduler {
}
}
@Override
public void schedule(final SchedulerKey key, final Runnable runnable, long delay, TimeUnit unit) {
Timeout timeout = executorService.newTimeout(new TimerTask() {
@Override
@ -91,6 +95,7 @@ public class HashedWheelScheduler implements CancelableScheduler {
}
}
@Override
public void shutdown() {
executorService.stop();
}

5
src/main/java/com/corundumstudio/socketio/scheduler/HashedWheelTimeoutScheduler.java

@ -45,6 +45,7 @@ public class HashedWheelTimeoutScheduler implements CancelableScheduler {
this.ctx = ctx;
}
@Override
public void cancel(SchedulerKey key) {
Timeout timeout = scheduledFutures.remove(key);
if (timeout != null) {
@ -52,6 +53,7 @@ public class HashedWheelTimeoutScheduler implements CancelableScheduler {
}
}
@Override
public void schedule(final Runnable runnable, long delay, TimeUnit unit) {
executorService.newTimeout(new TimerTask() {
@Override
@ -61,6 +63,7 @@ public class HashedWheelTimeoutScheduler implements CancelableScheduler {
}, delay, unit);
}
@Override
public void scheduleCallback(final SchedulerKey key, final Runnable runnable, long delay, TimeUnit unit) {
Timeout timeout = executorService.newTimeout(new TimerTask() {
@Override
@ -81,6 +84,7 @@ public class HashedWheelTimeoutScheduler implements CancelableScheduler {
replaceScheduledFuture(key, timeout);
}
@Override
public void schedule(final SchedulerKey key, final Runnable runnable, long delay, TimeUnit unit) {
Timeout timeout = executorService.newTimeout(new TimerTask() {
@Override
@ -96,6 +100,7 @@ public class HashedWheelTimeoutScheduler implements CancelableScheduler {
replaceScheduledFuture(key, timeout);
}
@Override
public void shutdown() {
executorService.stop();
}

1
src/main/java/com/corundumstudio/socketio/store/RedissonStoreFactory.java

@ -56,6 +56,7 @@ public class RedissonStoreFactory extends BaseStoreFactory {
return new RedissonStore(sessionId, redisClient);
}
@Override
public PubSubStore pubSubStore() {
return pubSubStore;
}

1
src/main/java/com/corundumstudio/socketio/store/pubsub/BaseStoreFactory.java

@ -34,6 +34,7 @@ public abstract class BaseStoreFactory implements StoreFactory {
return nodeId;
}
@Override
public void init(final NamespacesHub namespacesHub, final AuthorizeHandler authorizeHandler, JsonSupport jsonSupport) {
pubSubStore().subscribe(PubSubStore.DISCONNECT, new PubSubListener<DisconnectMessage>() {
@Override

Loading…
Cancel
Save