Merge pull request #290 from DevFactory/release/loggers-should-be-private-static-final

Code quality fix - Loggers should be private static final

src/main/java/com/corundumstudio/socketio/JsonSupportWrapper.java

@@ -29,7 +29,7 @@ import com.corundumstudio.socketio.protocol.JsonSupport;
 
 class JsonSupportWrapper implements JsonSupport {
 
-    private final Logger log = LoggerFactory.getLogger(getClass());
+    private static final Logger log = LoggerFactory.getLogger(JsonSupportWrapper.class);
 
     private final JsonSupport delegate;
 

src/main/java/com/corundumstudio/socketio/SocketIOChannelInitializer.java

@@ -71,7 +71,7 @@ public class SocketIOChannelInitializer extends ChannelInitializer<Channel> impl
     public static final String RESOURCE_HANDLER = "resourceHandler";
     public static final String WRONG_URL_HANDLER = "wrongUrlBlocker";
 
-    private final Logger log = LoggerFactory.getLogger(getClass());
+    private static final Logger log = LoggerFactory.getLogger(SocketIOChannelInitializer.class);
 
     private AckManager ackManager;
 

src/main/java/com/corundumstudio/socketio/SocketIOServer.java

@@ -47,7 +47,7 @@ import com.corundumstudio.socketio.namespace.NamespacesHub;
  */
 public class SocketIOServer implements ClientListeners {
 
-    private final Logger log = LoggerFactory.getLogger(getClass());
+    private static final Logger log = LoggerFactory.getLogger(SocketIOServer.class);
 
     private final Configuration configCopy;
     private final Configuration configuration;

src/main/java/com/corundumstudio/socketio/ack/AckManager.java

@@ -69,7 +69,7 @@ public class AckManager implements Disconnectable {
 
     }
 
-    private final Logger log = LoggerFactory.getLogger(getClass());
+    private static final Logger log = LoggerFactory.getLogger(AckManager.class);
 
     private final Map<UUID, AckEntry> ackEntries = PlatformDependent.newConcurrentHashMap();
 

src/main/java/com/corundumstudio/socketio/annotation/ScannerEngine.java

@@ -28,7 +28,7 @@ import com.corundumstudio.socketio.namespace.Namespace;
 
 public class ScannerEngine {
 
-    private final Logger log = LoggerFactory.getLogger(getClass());
+    private static final Logger log = LoggerFactory.getLogger(ScannerEngine.class);
 
     private static final List<? extends AnnotationScanner> annotations =
                     Arrays.asList(new OnConnectScanner(), new OnDisconnectScanner(), new OnEventScanner());

src/main/java/com/corundumstudio/socketio/annotation/SpringAnnotationScanner.java

@@ -33,7 +33,7 @@ import com.corundumstudio.socketio.SocketIOServer;
 
 public class SpringAnnotationScanner implements BeanPostProcessor {
 
-    private final Logger log = LoggerFactory.getLogger(getClass());
+    private static final Logger log = LoggerFactory.getLogger(SpringAnnotationScanner.class);
 
     private final List<Class<? extends Annotation>> annotations =
                     Arrays.asList(OnConnect.class, OnDisconnect.class, OnEvent.class);

src/main/java/com/corundumstudio/socketio/handler/AuthorizeHandler.java

@@ -61,7 +61,7 @@ import com.corundumstudio.socketio.store.pubsub.PubSubStore;
 @Sharable
 public class AuthorizeHandler extends ChannelInboundHandlerAdapter implements Disconnectable {
 
-    private final Logger log = LoggerFactory.getLogger(getClass());
+    private static final Logger log = LoggerFactory.getLogger(AuthorizeHandler.class);
 
     private final CancelableScheduler disconnectScheduler;
 

src/main/java/com/corundumstudio/socketio/handler/ClientHead.java

@@ -53,7 +53,7 @@ import io.netty.util.internal.PlatformDependent;
 
 public class ClientHead {
 
-    private final Logger log = LoggerFactory.getLogger(getClass());
+    private static final Logger log = LoggerFactory.getLogger(ClientHead.class);
 
     public static final AttributeKey<ClientHead> CLIENT = AttributeKey.<ClientHead>valueOf("client");
 

src/main/java/com/corundumstudio/socketio/handler/EncoderHandler.java

@@ -73,7 +73,7 @@ public class EncoderHandler extends ChannelOutboundHandlerAdapter {
     public static final AttributeKey<Integer> JSONP_INDEX = AttributeKey.valueOf("jsonpIndex");
     public static final AttributeKey<Boolean> WRITE_ONCE = AttributeKey.valueOf("writeOnce");
 
-    private final Logger log = LoggerFactory.getLogger(getClass());
+    private static final Logger log = LoggerFactory.getLogger(EncoderHandler.class);
 
     private final PacketEncoder encoder;
 

src/main/java/com/corundumstudio/socketio/handler/InPacketHandler.java

@@ -36,7 +36,7 @@ import com.corundumstudio.socketio.transport.NamespaceClient;
 @Sharable
 public class InPacketHandler extends SimpleChannelInboundHandler<PacketsMessage> {
 
-    private final Logger log = LoggerFactory.getLogger(getClass());
+    private static final Logger log = LoggerFactory.getLogger(InPacketHandler.class);
 
     private final PacketListener packetListener;
     private final PacketDecoder decoder;

src/main/java/com/corundumstudio/socketio/handler/ResourceHandler.java

@@ -60,7 +60,7 @@ import com.corundumstudio.socketio.SocketIOChannelInitializer;
 @Sharable
 public class ResourceHandler extends ChannelInboundHandlerAdapter {
 
-    private final Logger log = LoggerFactory.getLogger(getClass());
+    private static final Logger log = LoggerFactory.getLogger(ResourceHandler.class);
 
     public static final String HTTP_DATE_FORMAT = "EEE, dd MMM yyyy HH:mm:ss zzz";
     public static final String HTTP_DATE_GMT_TIMEZONE = "GMT";

src/main/java/com/corundumstudio/socketio/handler/WrongUrlHandler.java

@@ -35,7 +35,7 @@ import io.netty.handler.codec.http.QueryStringDecoder;
 @Sharable
 public class WrongUrlHandler extends ChannelInboundHandlerAdapter {
 
-    private final Logger log = LoggerFactory.getLogger(getClass());
+    private static final Logger log = LoggerFactory.getLogger(WrongUrlHandler.class);
 
     public void channelRead(ChannelHandlerContext ctx, Object msg) throws Exception {
         if (msg instanceof FullHttpRequest) {

src/main/java/com/corundumstudio/socketio/listener/DefaultExceptionListener.java

@@ -26,7 +26,7 @@ import com.corundumstudio.socketio.SocketIOClient;
 
 public class DefaultExceptionListener extends ExceptionListenerAdapter {
 
-    private final Logger log = LoggerFactory.getLogger(getClass());
+    private static final Logger log = LoggerFactory.getLogger(DefaultExceptionListener.class);
 
     @Override
     public void onEventException(Exception e, List<Object> args, SocketIOClient client) {

src/main/java/com/corundumstudio/socketio/protocol/JacksonJsonSupport.java

@@ -295,7 +295,7 @@ public class JacksonJsonSupport implements JsonSupport {
     private final EventDeserializer eventDeserializer = new EventDeserializer();
     private final AckArgsDeserializer ackArgsDeserializer = new AckArgsDeserializer();
 
-    private final Logger log = LoggerFactory.getLogger(getClass());
+    private static final Logger log = LoggerFactory.getLogger(JacksonJsonSupport.class);
 
     public JacksonJsonSupport() {
         this(new Module[] {});

src/main/java/com/corundumstudio/socketio/transport/NamespaceClient.java

@@ -35,7 +35,7 @@ import com.corundumstudio.socketio.protocol.PacketType;
 
 public class NamespaceClient implements SocketIOClient {
 
-    private final Logger log = LoggerFactory.getLogger(getClass());
+    private static final Logger log = LoggerFactory.getLogger(NamespaceClient.class);
 
     private final AtomicBoolean disconnected = new AtomicBoolean();
     private final ClientHead baseClient;

src/main/java/com/corundumstudio/socketio/transport/PollingTransport.java

@@ -51,7 +51,7 @@ public class PollingTransport extends ChannelInboundHandlerAdapter {
 
     public static final String NAME = "polling";
 
-    private final Logger log = LoggerFactory.getLogger(getClass());
+    private static final Logger log = LoggerFactory.getLogger(PollingTransport.class);
 
     private final PacketDecoder decoder;
     private final ClientsBox clientsBox;

src/main/java/com/corundumstudio/socketio/transport/WebSocketTransport.java

@@ -56,7 +56,7 @@ public class WebSocketTransport extends ChannelInboundHandlerAdapter {
 
     public static final String NAME = "websocket";
 
-    private final Logger log = LoggerFactory.getLogger(getClass());
+    private static final Logger log = LoggerFactory.getLogger(WebSocketTransport.class);
 
     private final AuthorizeHandler authorizeHandler;
     private final CancelableScheduler scheduler;