From 3cb91649f9a15ec0a8ece528d6a5d089a70f7a1d Mon Sep 17 00:00:00 2001 From: Nikita Koksharov Date: Thu, 29 Apr 2021 15:22:40 +0300 Subject: [PATCH] refactoring --- .../MultiRoomBroadcastOperations.java | 4 +-- .../SingleRoomBroadcastOperations.java | 4 +-- .../socketio/listener/DataListener.java | 3 +-- .../socketio/protocol/Packet.java | 3 +++ .../socketio/transport/BaseTransport.java | 25 ------------------- 5 files changed, 8 insertions(+), 31 deletions(-) delete mode 100644 src/main/java/com/corundumstudio/socketio/transport/BaseTransport.java diff --git a/src/main/java/com/corundumstudio/socketio/MultiRoomBroadcastOperations.java b/src/main/java/com/corundumstudio/socketio/MultiRoomBroadcastOperations.java index cac1744..aee3e05 100644 --- a/src/main/java/com/corundumstudio/socketio/MultiRoomBroadcastOperations.java +++ b/src/main/java/com/corundumstudio/socketio/MultiRoomBroadcastOperations.java @@ -22,8 +22,8 @@ import java.util.HashSet; import java.util.Set; /** - * @Author: liangjiaqi - * @Date: 2020/8/8 6:02 PM + * author: liangjiaqi + * date: 2020/8/8 6:02 PM */ public class MultiRoomBroadcastOperations implements BroadcastOperations { diff --git a/src/main/java/com/corundumstudio/socketio/SingleRoomBroadcastOperations.java b/src/main/java/com/corundumstudio/socketio/SingleRoomBroadcastOperations.java index 4f9ac67..a0c8719 100644 --- a/src/main/java/com/corundumstudio/socketio/SingleRoomBroadcastOperations.java +++ b/src/main/java/com/corundumstudio/socketio/SingleRoomBroadcastOperations.java @@ -26,8 +26,8 @@ import java.util.Arrays; import java.util.Collection; /** - * @Author: liangjiaqi - * @Date: 2020/8/8 6:08 PM + * Author: liangjiaqi + * Date: 2020/8/8 6:08 PM */ public class SingleRoomBroadcastOperations implements BroadcastOperations { private final String namespace; diff --git a/src/main/java/com/corundumstudio/socketio/listener/DataListener.java b/src/main/java/com/corundumstudio/socketio/listener/DataListener.java index c0bbe2f..4330a95 100644 --- a/src/main/java/com/corundumstudio/socketio/listener/DataListener.java +++ b/src/main/java/com/corundumstudio/socketio/listener/DataListener.java @@ -26,8 +26,7 @@ public interface DataListener { * @param client - receiver * @param data - received object * @param ackSender - ack request - * - * @throws Exception + * */ void onData(SocketIOClient client, T data, AckRequest ackSender) throws Exception; diff --git a/src/main/java/com/corundumstudio/socketio/protocol/Packet.java b/src/main/java/com/corundumstudio/socketio/protocol/Packet.java index 6360278..a517f9d 100644 --- a/src/main/java/com/corundumstudio/socketio/protocol/Packet.java +++ b/src/main/java/com/corundumstudio/socketio/protocol/Packet.java @@ -81,6 +81,9 @@ public class Packet implements Serializable { * Creates a copy of #{@link Packet} with new namespace set * if it differs from current namespace. * Otherwise, returns original object unchanged + * + * @param namespace + * @return packet */ public Packet withNsp(String namespace) { if (this.nsp.equalsIgnoreCase(namespace)) { diff --git a/src/main/java/com/corundumstudio/socketio/transport/BaseTransport.java b/src/main/java/com/corundumstudio/socketio/transport/BaseTransport.java deleted file mode 100644 index 74e6926..0000000 --- a/src/main/java/com/corundumstudio/socketio/transport/BaseTransport.java +++ /dev/null @@ -1,25 +0,0 @@ -/** - * Copyright (c) 2012-2019 Nikita Koksharov - * - * Licensed under the Apache License, Version 2.0 (the "License"); - * you may not use this file except in compliance with the License. - * You may obtain a copy of the License at - * - * http://www.apache.org/licenses/LICENSE-2.0 - * - * Unless required by applicable law or agreed to in writing, software - * distributed under the License is distributed on an "AS IS" BASIS, - * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. - * See the License for the specific language governing permissions and - * limitations under the License. - */ -package com.corundumstudio.socketio.transport; - -import io.netty.channel.ChannelInboundHandlerAdapter; - -import com.corundumstudio.socketio.Disconnectable; - -@Deprecated -public abstract class BaseTransport extends ChannelInboundHandlerAdapter implements Disconnectable { - -}